Are these still worth picking up now .
The new one will be announced/released in September so if you can hold your water then no.
If you can get one with any kind of significant discount then possibly but certainly not for £1000 at this point in its life cycle.
The rumour is that the X will be replaced and not drop down a tier.
Considering swapping my 8 for an X. What is the battery life like?
Again unless you can get a ‘deal’ why bother? It’s essentially the same phone under the screen. Swap it for the new one once it is out.