Cannot insert data into MySql table

drumdogg · 24 Jul 2012 at 15:02

Im having problem when i go to insert data from a table into MySql table.

Here is my php code:

Code:

<?php

$Date = $_POST['Date'];
$StartTime = $_POST['StartTime'];
$TestTime = $_POST['TestTime'];
$t1 = $_POST['t1'];
$t2 = $_POST['t2'];
$t3 = $_POST['t3'];
$t4 = $_POST['t4'];
$t5 = $_POST['t5'];
$t6 = $_POST['t6'];
$t7 = $_POST['t7'];
$t8 = $_POST['t8'];
$Initials = $_POST['Initials'];
$PassFail = $_POST['PassFail'];

mysql_connect("localhost","***","******");
mysql_select_db("*******");

$query="INSERT INTO testing (Date, StartTime, TestTime, t1, t2, t3, t4, t5, t6, t7, t8, Initials,PassFail)
VALUES
('NULL','".$Date."','".$StartTime."','".$TestTime."','".$t1."','".$t2."','".$t3."','".$t4."','".$t5."','".$t6."','".$t7."','".$t8."','".$Initials."','".$PassFail."')";

$result=mysql_query($query)or die('Error updating database');
?>

Im getting the 'error update database' message when i run that code and the data doesnt insert into mt table.

Any suggestions please??

GravyMonster · 24 Jul 2012 at 15:18

You're inserting 1 more field than you're listing. Try removing the 'NULL' from the start of the values.

As a side note, you really should be using some form of protection against SQL injection, as you're wide open with that code.

drumdogg · 24 Jul 2012 at 15:21

I have removed the 'NULL' and its still the same.
SQL Injection?? Could you explain please.

UncleRuckus · 24 Jul 2012 at 16:26

I basically means that someone could pull or remove data or even delete your entire database by manipulating your $_post variables, which would change the database query submitted.

sb89 · 24 Jul 2012 at 16:45

drumdogg said:
I have removed the 'NULL' and its still the same.
SQL Injection?? Could you explain please.

Craig321 · 24 Jul 2012 at 16:48

drumdogg said:
I have removed the 'NULL' and its still the same.
SQL Injection?? Could you explain please.

http://php.robm.me.uk/

drumdogg · 25 Jul 2012 at 08:20

Ok guys thanks for the explanation.

But i still cant get this code to work

Any other ideas??

Linkex · 25 Jul 2012 at 08:45

Replace

Code:

$result=mysql_query($query)or die('Error updating database');

with

Code:

$result=mysql_query($query);
echo 'Sql query: ' . $query . '<br><br>Mysql error: ';
print_r(mysql_error());

Should give you a reasonable idea of what the problem it.

drumdogg · 25 Jul 2012 at 09:11

Ok thanks that helped me find some errors

If i run the php file on its own it inserts a blank row into the database as it should.

But if i enter the data into the form and hit submit nothing inserts into the database.

Must be something wrong with my submit button!

I have the form action pointing to the php file and the method=post.

Is that correct??

drumdogg · 25 Jul 2012 at 10:46

Right guys got it sorted

Thanks for the help

Cheers

Linkex · 25 Jul 2012 at 10:46

sounds correct. can you post the form so we can have a look?