I don't fully understand your current setup. Do you have 1 network or 2? If you have 2, do you basically NAT traffic from PC's connected to the cable router into the other network, and then again before it goes out into the internet?
Here are some ways how you might tackle this problem.. (it'd be simpler if you were happy with the two VLANs talking to each other)
Option 1. Here's roughly what you need to do:
- A VLAN-capable switch (maybe your ADSL or cable router can already do that with aftermarket firmware, or use a smart switch)
- A separate or integrated router
- The router needs to be able to apply separate firewall rules on each of the two vlan interfaces.
On the router, you configure two home-network-facing interfaces, one with say 192.168.1.1/24, the other with say 192.168.2.1/24 (/24 means subnet mask of 255.255.255.0). These interfaces need firewall rules to block traffic destined to the other network, i.e. 192.168.2.x and 192.168.1.x, respectively. Then, on the switch, you distribute your ports into 2 vlans, and patch one of the router interfaces into each VLAN. You will also need to setup NAT between each of these interfaces and the WAN (internet-facing) interface, as appropriate.
If your router and switch support 802.1q trunk ports, you can use one physical cable, and virtual/subinterfaces on the router, rather than 2 cables between the router and the switch.
If you were OK with the two networks talking to each other, it'd be a bit simpler.
It's possible to do this all in one sophisticated device.
Option 2: setup something like this:
This might be a bit more round-about, but it might be easier to do with your existing hardware.
Firewall configuration:
- it needs 2 interfaces, one in each network, so that it has IP addresses in each network. (say 192.168.1.2 and 192.168.2.1)
- it needs firewall rules to enforce the separation of the two networks. Be careful how you handle the exception for the upstream router.
- The default gateway is set to the router's IP address
The ADSL router would need a static route, saying that 192.168.2.0/24 is reachable via 192.168.1.2, otherwise return traffic won't make it back to PC's in (blue) VLAN 3. You may also wish to install firewall rules here.
Depending on how much you care about security, you need to be really careful and consider all the possible traffic paths, including PC in vlan 2 -> ADSL router -> (NAT) -> firewall -> PC in vlan 3.. This should apply to all options you might consider.
PS: I find that diagrams like the above really help with understanding these sorts of setups. I drew mine with draw.io, and just searched for router etc to get the icons. Quite handy.