DELETED_5350

Gman · 17 Mar 2006 at 17:03

Well the 2 errors are because:

1: there is no background attribute for the td tag take it out

2: there is no alt attribute for a td tag :- take it out

design wise I could add some padding to you menu apart from that it looks ok. nothing outstanding but it works.

Code wise you need to drop the tables and start using an external style sheet to style everything. Doing it without tables you could cut down your html code to a quarter of what it is now.

Mr_L · 17 Mar 2006 at 17:08

I think it looks better than the old one, but I can't entirely remember how that looked. Nice, simple and clean and only a couple of errors so that's pretty good.

Gman is right though, an external stylesheet, XHTML and no tables would be a lot better and search engines would like you more with a bit of tweaking.

Al Vallario · 17 Mar 2006 at 17:35

From a purely visual perspective it looks quite good. You could make the Google ads fit in a bit more, and style the "Terms of Service" link at the bottom of the page to be the same colour as the rest of the footer text and thus fit in. I personally think the upload box should be placed further up the page (Why not put it alongside the paragraphs of text which repeat visitors won't really care about?)

The source code isn't very impressive, however. Tables are so 2005, and you're not utilising your external stylesheet enough. If I had my way, there wouldn't be a single character of style information in the HTML file; the basic structure and text of your site should be in your HTML file, all the style should be in your CSS file

Boycie · 18 Mar 2006 at 17:25

Why are tables bad? Do search engines not like them?

Gman · 18 Mar 2006 at 18:24

Boycie said:
Why are tables bad? Do search engines not like them?

here are 10 reasons taken from http://phrogz.net/CSS/WhyTablesAreBadForLayout.html

1. Tables are usually more bytes of markup. (Longer to download, and more bytes of traffic for the host.)
2. Tables are usually slower to layout for the browser. (Takes longer for the user to see anything on the page.)
3. Tables usually prevent incremental rendering. (Takes longer for the user to see anything on the page.)
4. Tables may require you to chop single, logical images into multiple ones. (This makes redesigns total hell, and also increases page load time [more http requests and more total bytes].)
5. Tables break text copying on some browsers. (That's annoying to the user.)
6. Tables prevent certain layouts from working within them (like height:100% for child elements of <td>). (They limit what you can actually do in terms of layout.)
7. Once you know CSS, table-based layouts usually take more time to implement. (A little effort up-front learning CSS pays off heavily in the end.)
8. Tables are semantically incorrect markup for layout. (They describe the presentation, not the content.)
9. Tables make life hell for those using screen readers. (Not only do you get the other benefits of CSS, you're also helping out the blind/partially-sighted. This is a Good Thing.)
10. Tables lock you into the current design and make redesigns MUCH harder than semantic HTML+CSS. (Have you seen CSS Zen Garden?)

Al Vallario · 18 Mar 2006 at 20:57

smoove said:
Not sure what you mean by "make google ads fit in more", since theres no other possible way to have it on the page lol.

I mean possibly getting rid of the orange border and making the text colour the same as the rest of the text on the page. It may sound unethical, but one of the ways people get more ad clicks is by blending the links into the rest of the site so much that users can't tell they're ads.

I think you'd be better off by using a 250x250 "Square" ad block on the left hand side, and putting the paragraphs of text (perhaps cut down on the text, and put more information further down the page, in a less valuable position) and upload form on the right hand side

Gman · 19 Mar 2006 at 12:32

smoove said:
Right I've had another fiddle, cut out some of the text, changed the google ads colour (think it loooks better or worse).

But i still dont understand this error:

1: there is no background attribute for the td tag take it out

I take it out and replace it with: img src and then it tells me that is wrong.

Any ideas?

I think you can only have background images for tables not table cells.
but its been a long time since i've gone the tables route

Augmented · 19 Mar 2006 at 14:13

There's a problem with the flow of your error-handling. If I attempt to upload no file, it returns the error "You did not upload a file!" and the layout appears to be broken.

I have to press back on my browser to try again (would be better to place the error message above the form), but I hit a problem. The 'Upload' button is disabled and displaying 'Uploading...' preventing me from continuing. Likewise for the "That file type is not supported!" error

.

Gman · 19 Mar 2006 at 20:33

smoove said:
I've tried replacing it with img src, but still get problems?

Thanks for spotting that Augmented, I'll get on them now

what do you mean you;ve replaced it with <img src="" ??
post the code so we can have a look

serlex · 19 Mar 2006 at 22:58

off topic! gman from gather.uk?

Gman · 19 Mar 2006 at 23:05

serlex said:
off topic! gman from gather.uk?

Nope never been there before (take it it's an irc chan?). This is realy the only forum I go by Gman on every other one I go with agentwalker as Gman tends to be popular, well every since HalfLife it has (dam game making my nick overused)

Gman · 25 Mar 2006 at 17:25

smoove said:
<td height="24" align="center" background="template/nav_img.jpg">

Still dont understand what Im supposed to replace "background" with?

Augmented, Im stuck on how to fix that error handling problem

just had a look at you can have the background attribute on the td tag BUT its been depreciated and will therefore throw an error when trying to validate your code.

Your best bet is to use a stylesheet, place a class or id on that particular td and use the stylesheet to insert the background.

Gman · 26 Mar 2006 at 21:02

smoove said:
Thanks, im not to good on code, so I would do the following yea?

.back_image {
background: url(image.jpg) no-repeat;
height:24
align:center
}

yep your code *should* work but you might be better including the no-repeat section at the ent of the background line. that way it stops it from repeating *thats if you don't want it to*

Al Vallario · 27 Mar 2006 at 00:06

smoove said:
Thanks, im not to good on code, so I would do the following yea?

.back_image {
background: url(template/nav_img.jpg);
height:24
align:center
}

You need to add more information to the background attribute (eg. background: url("template/nav_img.jpg") left top no-repeat #fff;). What measurement is the height in; px, em, giraffes? I presume you want height: 24px;. There's no such CSS attribute as align. There is, however, text-align if you're looking to center the content of an object. Also remember that every line of style information within the {}'s must be followed with a semi-colon. You've missed semi-colons out on the height (and the non-existant align attribute) and this will break your CSS

Here's the code all fixed:

Code:

.back_image {
background: url("template/nav_img.jpg") left top no-repeat #fff;
height:24px;
}

av.