Well I have just upgraded to 4gb yesterday (2.2ghz MBP). In normal usage proly youre not gonna notice much difference, but once i had vmware fusion running XP, photoshop, itunes, firefox,mail, adium etc all running at once thats where the 4gb really comes in useful as theres no slowdown anymore when switiching between apps.
So in summary, open up Activity monitor, if you see a lot of page outs and you freqeuntly find yourself with very little free ram then its gd to upgrade. Its pretty cheap anywy so if you need it go for it!