if statement help in php

craptakular · 29 Jan 2012 at 15:40

I have the following as an if statement:

PHP:

if ($ThisWeeksResults != $LastWeeksResults) {
	print '$ThisWeeksResults';
	}
	else {
	print 'either the numbers are equal to each other or there isnt numerics in this weeks results';
	}

How do I make sure that the if statement checks that $ThisWeeksResults isn't equal to $LastWeeksResults AND that $ThisWeeksResults is_numeric?

GravyMonster · 29 Jan 2012 at 15:43

You need to use the logical AND operator: &&

Code:

if ($ThisWeeksResults != $LastWeeksResults && is_numeric($ThisWeeksResults)) {
    print '$ThisWeeksResults';
}
else {
    print 'either the numbers are equal to each other or there isnt numerics in this weeks results';
}

More info

Woden · 29 Jan 2012 at 15:43

Put "print '$ThisWeeksResults';" inside another if statement

craptakular · 29 Jan 2012 at 15:44

Thanks mate! I am learnin'

IS this a good check though?

It suddenly came into my brain that I needed to check the data or I could have a right mess if it ever goes wrong...

Mattius · 31 Jan 2012 at 17:11

If your learning, split it down so you have simple error messages so you know where its going wrong, nothing wrong with that code though.

i.e.

Code:

if (!is_numeric($ThisWeeksResults)){
  Print 'This week not numeric';
}else{
  if($ThisWeeksResults != $LastWeeksResults){
      Print 'This weeks  result';
  }else{
      Print 'Numbers are identical';
  }
}

Depends where $ThisWeeksResults is coming from though whether you need it, if its a calculation your calculation should have the error, if its user input then that should have some error checking before submits it.
Just before its printing is really the last place you wanna see someone as basic as is it numeric.