Java, downloading files

[k++]

I'm having trouble downloading a rather large text file using java, specifically this:

map.sql

Unfortunately when the file is downloaded I find it isn't complete, and infact the last 20 or so entries are missing

my code:

public void download(String address, String filePath) {
    try {
      URL url = new URL(address);
      URLConnection urlConnection = url.openConnection();
      urlConnection.connect();
      InputStream input = url.openStream();
      FileWriter fw = new FileWriter("map.txt");
      BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(input));
      String tString = bufferedReader.readLine();
      while (tString != null) {
        fw.write(tString);
        tString = bufferedReader.readLine();
      }
    } catch(Exception exception) {
      exception.printStackTrace();
    }
  }

Any suggestions?

 

[k++]

I'm suspecting it's something to do with file sizes, as I have found that printing to the terminal displays the whole file.

What on earth could be going on. I have used a code snippet from the web thinking it was my code so I am now using

public void download(String address, String filePath) {
    try { 
      URL url = new URL(address); 
      InputStream inputStream = url.openStream();
      FileWriter fileWriter = new FileWriter(filePath); 
      byte[] buf = new byte[1024]; 
      int len; 
      while((len = inputStream.read(buf)) > 0 ) { 
        for(int i = 0; i < len; i++) { 
          fileWriter.write((char)buf[i]);
        } 
      }  
      inputStream.close(); 
    }
    catch (MalformedURLException exception) {
      exception.printStackTrace();
    }
    catch (IOException exception) {
      System.err.println("File not found : " + address);
    } 
    finally {
      System.out.println("FINALLY");
    }
  }

Just slightly modified

 

[Una]

Odd hmm, only thing I can think of is that it could possibly be getting a termination to the end of stream early.

Weird stops writing after, INSERT INTO `x_world` VALUES (39288

EDIT: I thought it was a problem with the buffered writer but it seems that the inputstream is incomplete...

 

[k++]

I have taken to working with the file on the fly, it will do for what I'm trying to achieve. I wanted to create an archive of different versions so I could monitor changes. Still achievable though I guess.

 

[Una]

Aright all fixed,

import java.io.*;
import java.util.*;
import java.net.*;

public class Test
{
	public static void main(String[] args)
	{
		BufferedWriter bw;
		Scanner sc;
		InputStream input;
		URL url;
		URLConnection urlConnection;
		try
		{
			url = new URL(args[0]);
			urlConnection = url.openConnection();
			urlConnection.connect();
			input = url.openStream();
			sc = new Scanner(input);
			bw = new BufferedWriter(new FileWriter("map.txt"));

			while (sc.hasNext())
			{
				bw.write(sc.nextLine() + "\n");
			}
			bw.close();
                        input.close();
		}
		catch (Exception e) { e.printStackTrace(); }
	}
}

Edit: And yeah the problem was he forgot to flush the writer yep.

 

[Lagz]

Incase you were wondering what was wrong, I think it is probably because you forgot to flush the writer (the writer probably has an internal buffer for efficiency, so you need to call flush to force the buffered data to be written to file). I think the last version works because you close the writer, which probably does a flush for you before it closes.

 

[k++]

Thanks for that Una, I'm off to bed now so I'll try tomorrow after work. I understand now what my problem was.

goodnight

Karl