Java/jsp help.

[Energize]

I'm trying to run this simple code which checks if a password exists in an xml user file.

for (int y = 0; y < passwords.getLength(); y++) {
	if (password == passwords.item(y).getTextContent()) {
		out.println("yes");
	}	
}

But everytime I run this nothing prints out on the web page! I have no problem using the .getTextContent to print out a list of all users passwords, but this comparison statement never evaluates to true for some reason, using .equals() even gives me a nullpointer exception!

 

[Dj_Jestar]

String comparisons must use .equals() so change your statement to:

for (int y = 0; y < passwords.getLength(); y++) {
	if (passwords.item(y).getTextContent() != null && passwords.item(y).getTextContent().equals(password)) {
		out.println("yes");
	}	
}

 

[PaulStat]

String comparisons must use .equals() so change your statement to:

for (int y = 0; y < passwords.getLength(); y++) {
	if (passwords.item(y).getTextContent() != null && passwords.item(y).getTextContent().equals(password)) {
		out.println("yes");
	}	
}

Yup, just as an extra note try compiling the following and see what you get

String s1 = "Hello";
String s2 = "Hello";
String s3 = new String("Hello");
String s4 = new String("Hello");
System.out.println(s1==s2);
System.out.println(s3==s4);
System.out.println(s3.equals(s4));

You'll get true false true, this is all to do with the String pool and reference variables.

 

[Energize]

I found out why I was getting a null pointer exception when using .equals(), I had given the password textbox the wrong id.