JavaScipt

kola · 9 Nov 2011 at 21:34

Trying to use a Img instead of the crappy look grey button code 1 work's fine but my code in 2 doesnt any ideas, sorry inadvance

. Iv'e googled and my code looks fine :confused:

1

Code:

<tr><td><center><input type="button" value="Login" onClick="pasuser(this.form)">

2

Code:

<tr><td><center><input type="image" img src="login.png" onClick="pasuser(this.form)">

RobH · 9 Nov 2011 at 22:31

That random "img" attribute floating around in the tag might be causing the problem.

kola · 9 Nov 2011 at 22:43

RobH said:
That random "img" attribute floating around in the tag might be causing the problem.

thought you had it , nah still doesnt work .

numnutz · 9 Nov 2011 at 22:58

Can you be more specific when you say doesn't work? What error's do you get in the console?

Sherbs · 9 Nov 2011 at 23:40

Just use CSS or JS to target the button?

edit: If you can post a link that'd be handy.

GravyMonster · 10 Nov 2011 at 09:03

The problem is because the input type="image" will submit the form before it runs any code you put in the onclick handler, and because the form submission causes a redirect, the onclick code will never be run.

You either need to change the input to an image with the click handler on it (and make sure you also call form.submit() in there), or remove the click handler from the image input and add an onsubmit handler to the form.

kola · 10 Nov 2011 at 19:24

Spunkey said:
The problem is because the input type="image" will submit the form before it runs any code you put in the onclick handler, and because the form submission causes a redirect, the onclick code will never be run.

You either need to change the input to an image with the click handler on it (and make sure you also call form.submit() in there), or remove the click handler from the image input and add an onsubmit handler to the form.

sorted thanks for the help m8 ,

Code:

<a href="JavaScript:pasuser(form)"> <img src="login.png"</a>

Phunky · 11 Nov 2011 at 09:34

Use the button element instead

Code:

<button onclick="pasuser(this.form)">Yo!</button>

And if that is submitting your form, move it to the onSubmit of the form itself and just add type attribute of submit to the button ie:

Code:

<form onsubmit="pauser(this.form)">
<button type="submit">Yo!</button>
</form