Passing PHP Variable to JS Var within a HereDoc

kitkat9933 · 13 Mar 2014 at 20:58

Hi, I have a foreach loop, roughly as shown below, excluding the unimportant stuff.

I am trying to pass to PHP variables based on the progress within the foreach loop, to a JavaScript function. The variables get passed right to the HTML feed,just not the JS function. The variables I need to pass to the js function are $feed->name and $feed->URL.

I read up elsewhere that the best way to pass these to the JS function as parameters is to set them as JS variables first and then use these as parameters to the function.

So in this case I need to set

Code:

<script>
var feedName=<?php echo $feed->name ;?>
var feedUrl= <?php echo $feed->url ;?>
</script>

However, I just can't get this to work within the heredoc, no matter what I've tried which i've found online, as obviously it gets processed as the literal value rather than a variable. I am not very knowledgeable in JS, just to let you know.

Any help would be more appreciated.

PHP:

	foreach($rss_feeds as $feed)
	{		
		 echo <<< HTML
			<tr>
				<td><form action="router.php" method="post">
					<input name="edit-feed" type="hidden" value="$feed->id" />
					<input name="edit-feed-submit" type="submit" value="Edit" class="edit-feed-button" onclick="javascript:modify_feed(feedName,feedUrl);" /></form>
				</td>
				
			</tr>
HTML;
	}

visibleman · 13 Mar 2014 at 22:16

I believe you need to surround variables within HereDoc in curly brackets, so -

Code:

<input name="edit-feed" type="hidden" value="{$feed->id}" />

kitkat9933 · 14 Mar 2014 at 00:49

visibleman said:
I believe you need to surround variables within HereDoc in curly brackets, so -

Code:

<input name="edit-feed" type="hidden" value="{$feed->id}" />

The variables get outputted right in the HTML , it's just my JS function isn't . I have made the op clearer regarding this (I hope)!

xbenjiiman · 14 Mar 2014 at 07:53

Don't forget, if it's a string you're passing to the JavaScript variable, it needs to be encapsulated in quotes.

PHP:

var myVar = '<?PHP echo $var; ?>';

planty · 14 Mar 2014 at 09:25

Shouldn't you be updating the value of the javascript variable within your foreach loop?

xbenjiiman · 14 Mar 2014 at 09:33

Wouldn't it just be the case of:

PHP:

onclick="javascript:modify_feed('$feed->name','$feed->url');"

http://3v4l.org/ZFBnS

planty · 14 Mar 2014 at 09:42

^^ This would be my preference - not really sure what the point of the javascript variables are in this instance.

kitkat9933 · 14 Mar 2014 at 11:51

xbenjiiman said:
Wouldn't it just be the case of:

PHP:

onclick="javascript:modify_feed('$feed->name','$feed->url');"

http://3v4l.org/ZFBnS

That is what I originally assumed, but it isn't working within the heredoc.

planty said:
^^ This would be my preference - not really sure what the point of the javascript variables are in this instance.

I am using a JS function which gives the user a prompt where they can edit the variable, based on which item they clicked.

kitkat9933 · 14 Mar 2014 at 11:53

planty said:
Shouldn't you be updating the value of the javascript variable within your foreach loop?

It actually is in the foreach loop, just didn't include in this example.

visibleman · 14 Mar 2014 at 14:19

kitkat9933 said:
That is what I originally assumed, but it isn't working within the heredoc.

Did it produce any errors?
Obviously xbenjiiman's example clearly works, so can you post the source you used?

kitkat9933 · 14 Mar 2014 at 14:48

visibleman said:
Did it produce any errors?
Obviously xbenjiiman's example clearly works, so can you post the source you used?

It just passes the literal value ' $feed->name '

xbenjiiman · 14 Mar 2014 at 15:13

kitkat9933 said:
It just passes the literal value ' $feed->name '

Can you post the code you're using?

kitkat9933 · 14 Mar 2014 at 18:03

xbenjiiman said:
Can you post the code you're using?

I came back to it today from work and it just worked!

Code:

onclick="javascript:modify_feed('$feed->name','$feed->url');">

Maybe I was being stupid as it was so late last night.

xbenjiiman · 14 Mar 2014 at 19:02

kitkat9933 said:
I came back to it today from work and it just worked!

Code:

onclick="javascript:modify_feed('$feed->name','$feed->url');">

Maybe I was being stupid as it was so late last night.

Maybe you were using nowdoc, since that stores the string literal

PHP:

<<<EOT

vs

PHP:

<<<'EOT'

kitkat9933 · 14 Mar 2014 at 19:41

xbenjiiman said:
Maybe you were using nowdoc, since that stores the string literal

PHP:

<<<EOT

vs

PHP:

<<<'EOT'

Anyway thanks for the help guys. Now I can finish this project for this Job Application.