PHP Echo Incorrect

denby · 2 Jan 2013 at 14:57

hi all

im having a little trouble with a PHP Echo

PHP:

<?php
$strSQL = "SELECT * FROM  game";
$result = mysql_query($strSQL);
$row = mysql_fetch_assoc($result);
$chkbox1        = $row['chkbx1'];
$chkbox2        = $row['chkbx2'];
       
echo '
<!DOCTYPE html>
<html>
<head>
<script src="http://code.jquery.com/jquery-1.8.2.min.js"></script>
<meta charset=utf-8 />
<title></title>
</head>
<body>
<table>
        <tr>
                <td>1</td>


                <td><input type="checkbox" name="chkbox1" value="1"
 ';
                                if ($chkbox1 == 1)
                                {
                                        echo ' checked="checked"> ';
                                       
                               }
                                
                               
                                
echo '                 
               
        </tr>
        <tr>
                <td>2</td>
                <td><input type="checkbox" name="chkbox2" value="1"
                ';
                                if ($chkbox2 == 1)
                                {
                                        echo ' checked="checked"> ';
                                }
 
                        echo '
                </td>
        </tr>
</table>
  <div style="display:none">0</div>
</body>
</html>

';
?>

now if you look at the output

i need them both to read

Code:

 checked="checked">

however this does not work

any ideas?

Craig321 · 2 Jan 2013 at 15:07

You should probably echo the last ">" outside the if statement. Currently if chkbox1/2 = 0 then it's never going to output >.

That should also fix the problem you're having.

AHarvey · 2 Jan 2013 at 15:10

not checked the code in a live environment, but that is missing a </td> after your first input checkbox

cheechm · 2 Jan 2013 at 16:48

Also I thought it was

Code:

<input type="checkbox" name="chkbox1" checked>

?

visibleman · 2 Jan 2013 at 19:37

As Craig321 mentioned, you should move the end chevron outside the IF statement otherwise if the condition fails then no end chevron is added to the input tag.

Try (short-tags replace echo, ternary IF's used) -

Code:

<?php
$strSQL = "SELECT `chkbx1`, `chkbx2` FROM `game`";
$result = mysql_query($strSQL);
$row = mysql_fetch_assoc($result);
$chkbox1 = $row['chkbx1'];
$chkbox2 = $row['chkbx2'];
?>
<!DOCTYPE html>
<html>
<head>
<script src="http://code.jquery.com/jquery-1.8.2.min.js"></script>
<meta charset=utf-8 />
<title></title>
</head>
<body>
<table>
    <tr>
        <td>1</td>
        <input type="checkbox" se
        <td><input type="checkbox" name="chkbox1" value="1"<?=($chkbox1 == 1)?' checked="checked"':''?>></td>
    </tr>
    <tr>
        <td>2</td>
        <td><input type="checkbox" name="chkbox2" value="1"<?=($chkbox2 == 1)?' checked="checked"':''?>></td>
    </tr>
</table>
<div style="display:none">0</div>
</body>
</html>

cheechm · 2 Jan 2013 at 19:43

Short tags are great if the server supports it (which I'm sure it does), but isn't best practice still <?php echo ?

visibleman · 2 Jan 2013 at 19:47

cheechm said:
Short tags are great if the server supports it (which I'm sure it does), but isn't best practice still <?php echo ?

Perhaps if you're pre-5.4 and/or dealing with XML.

GravyMonster · 2 Jan 2013 at 20:17

cheechm said:
Also I thought it was

Code:

<input type="checkbox" name="chkbox1" checked>

?

Technically that is true and will work, I think it won't pass validation unless the 'checked' attribute is given a value (preferably either 'checked=checked' or 'checked=true')

denby · 2 Jan 2013 at 22:06

visibleman said:

As Craig321 mentioned, you should move the end chevron outside the IF statement otherwise if the condition fails then no end chevron is added to the input tag.

Try (short-tags replace echo, ternary IF's used) -

Code:

<?php
$strSQL = "SELECT `chkbx1`, `chkbx2` FROM `game`";
$result = mysql_query($strSQL);
$row = mysql_fetch_assoc($result);
$chkbox1 = $row['chkbx1'];
$chkbox2 = $row['chkbx2'];
?>
<!DOCTYPE html>
<html>
<head>
<script src="http://code.jquery.com/jquery-1.8.2.min.js"></script>
<meta charset=utf-8 />
<title></title>
</head>
<body>
<table>
    <tr>
        <td>1</td>
        <input type="checkbox" se
        <td><input type="checkbox" name="chkbox1" value="1"<?=($chkbox1 == 1)?' checked="checked"':''?>></td>
    </tr>
    <tr>
        <td>2</td>
        <td><input type="checkbox" name="chkbox2" value="1"<?=($chkbox2 == 1)?' checked="checked"':''?>></td>
    </tr>
</table>
<div style="display:none">0</div>
</body>
</html>

thanks that worked great