php function help

[hargi]

I have a page and an include file and im trying to make a function to make my code reusable.

original code in full that works

<?php 
$result = mysql_query("SELECT price FROM catalogue WHERE item = 'whitetshirt'");
if (!$result) {
    die("no such field");
}

$Row = mysql_fetch_array( $result );
$Displayprice = $Row['price']/100;

echo "£$Displayprice";

I tried spliting it up
this is in my include file

<?php
function itemdisplayprice(){
$Row = mysql_fetch_array( $result );
$Displayprice = $Row['price']/100;
// convert price from pence to pounds
echo "£$Displayprice";
}
?>

in proper page

<?php 
				 
$result = mysql_query("SELECT price FROM catalogue WHERE item = 'whitetshirt'");
if (!$result) {
    die("No such feild");
}
				itemdisplayprice
				?>

 

[NightmareXX]

<?php
function itemdisplayprice($result)
{
  $Row = mysql_fetch_array( $result );
  $Displayprice = $Row['price']/100;
  // convert price from pence to pounds
  echo "£$Displayprice";
}
?>

<?php 
$result = mysql_query("SELECT price FROM catalogue WHERE item = 'whitetshirt'");
if (!$result) {
    die("No such feild");
}
itemdisplayprice($result);
?>

I think that should work, been a while since I've looked at PHP function passes.

The problem was that you weren't passing the result of your MySQL query to the function so it was trying to use a variable that doesn't exist.

The only way a function can access a variable outside of itself is if that variable is declared global. Otherwise the only things it can access are variables passed in as parameters.

 

[hargi]

thanks that works a treat. I though it was something along those lines