PHP - is this bad practice?

[suarve]

Hi,

For a lot of my old projects I used a simple class called Tools, with static methods for things like filter input and other basic, common tasks. I'd include this class on the desired page. If I wanted to call one of the classes methods I'd then do Tools::somemethod();

Is this really bad practice? Only reason I ask is because a customers relative is apparently a 'top' php developer and pointed out that uses classes in this way is seriously bad practice. The customer is a bit concerned.

Have I dropped a ball here?

Thanks

 

[suarve]

Right, have decided to toptally ignore anything this tool says from now on as he's just been on the phone to me. He said he'd been looking over the source code the site and noticed another 'issue' as he put it.

Told me when I'm outputting options for a drop down I should be using a tab (\t) and not just a new line (\n) for each option (yes, he thought this required a phone call). Okay, so the select options are aligned to the far left whern you view the page source from your browser, this makes bugger all difference to anything.

 

[suarve]

Quick, set up a conference call with all parties involved and debate this meaningful and significant problem of tabs vs newlines.

Hell.. if it were me developing it, he'd be lucky to get any white space at all in the mark-up

Hehe