PHP syntax error help

craptakular · 24 Mar 2012 at 12:50

PHP:

foreach ($variable1 as $element) {
	if ($variable1 != $LastWeeksVariable && is_numeric($element) && $d=="Tue") {
        mysql_query("INSERT INTO table1 
					(idproducts, info1, info2, info3, info4, info5, info6, fullinfo1, drawndate, drawnyear) VALUES('9', '$variable1[0]', '$variable1[1]', '$variable1[2]', '$variable1[3]', '$variable1[4]', '$variable1[5]', '$variable1[6]', NOW(), NOW())") 
or die(mysql_error());  

mysql_query("UPDATE table2 SET dates = DATE_ADD(DATE_ADD(DATE(NOW() + INTERVAL 2 DAY), INTERVAL 19 HOUR), INTERVAL 00 MINUTE)
			WHERE idsomething = '9'")
    or die(mysql_error());

		break 1;
	foreach ($variable1 as $element) {
	} if ($variable1 != $LastWeeksVariable && is_numeric($element) && $d=="Thu") {
        mysql_query("INSERT INTO table1 
					(idproducts, info1, info2, info3, info4, info5, info6, fullinfo1, drawndate, drawnyear) VALUES('9', '$variable1[0]', '$variable1[1]', '$variable1[2]', '$variable1[3]', '$variable1[4]', '$variable1[5]', '$variable1[6]', NOW(), NOW())") 
or die(mysql_error());  

mysql_query("UPDATE table2 SET dates = DATE_ADD(DATE_ADD(DATE(NOW() + INTERVAL 2 DAY), INTERVAL 19 HOUR), INTERVAL 00 MINUTE)
			WHERE idsomething = '9'")
    or die(mysql_error());

		break 1;
	
	foreach ($variable1 as $element) {	
	} if ($variable1 != $LastWeeksVariable && is_numeric($element) && $d=="Sat") {
        mysql_query("INSERT INTO table1 
					(idproducts, info1, info2, info3, info4, info5, info6, fullinfo1, drawndate, drawnyear) VALUES('9', '$variable1[0]', '$variable1[1]', '$variable1[2]', '$variable1[3]', '$variable1[4]', '$variable1[5]', '$variable1[6]', NOW(), NOW())") 
or die(mysql_error());  

mysql_query("UPDATE table2 SET dates = DATE_ADD(DATE_ADD(DATE(NOW() + INTERVAL 3 DAY), INTERVAL 19 HOUR), INTERVAL 00 MINUTE)
			WHERE idsomething = '9'")
    or die(mysql_error());

		break 1;
	
		} else {
        echo "'{$element}' is NOT numeric or results same as last week, or It isn't Thursday", PHP_EOL;
    }
}

mysql_close();

Can anyone spot the syntax error?

zpos · 24 Mar 2012 at 13:24

You going to give us a line number or the actual error message?

craptakular · 24 Mar 2012 at 13:31

Parse error: syntax error, unexpected T_ELSE

FabienO · 24 Mar 2012 at 13:54

PHP:

foreach ($variable1 as $element) {     
    } if ($variable1 != $LastWeeksVariable && is_numeric($element) && $d=="Sat") {

Does your editor highlight the opposite bracket when you select one? there's nothing in that foreach loop.

PHP:

foreach ($variable1 as $element) {
	if ($variable1 != $LastWeeksVariable && is_numeric($element) && $d == "Tue") {
		mysql_query("INSERT INTO table1  
                    (idproducts, info1, info2, info3, info4, info5, info6, fullinfo1, drawndate, drawnyear) VALUES('9', '$variable1[0]', '$variable1[1]', '$variable1[2]', '$variable1[3]', '$variable1[4]', '$variable1[5]', '$variable1[6]', NOW(), NOW())")
				or die(mysql_error());

		mysql_query("UPDATE table2 SET dates = DATE_ADD(DATE_ADD(DATE(NOW() + INTERVAL 2 DAY), INTERVAL 19 HOUR), INTERVAL 00 MINUTE) 
            WHERE idsomething = '9'")
				or die(mysql_error());

		break 1;
	}
		foreach ($variable1 as $element) {
			if ($variable1 != $LastWeeksVariable && is_numeric($element) && $d == "Thu") {
				mysql_query("INSERT INTO table1  
                    (idproducts, info1, info2, info3, info4, info5, info6, fullinfo1, drawndate, drawnyear) VALUES('9', '$variable1[0]', '$variable1[1]', '$variable1[2]', '$variable1[3]', '$variable1[4]', '$variable1[5]', '$variable1[6]', NOW(), NOW())")
						or die(mysql_error());

				mysql_query("UPDATE table2 SET dates = DATE_ADD(DATE_ADD(DATE(NOW() + INTERVAL 2 DAY), INTERVAL 19 HOUR), INTERVAL 00 MINUTE) 
            WHERE idsomething = '9'")
						or die(mysql_error());

				break 1;

				if ($variable1 != $LastWeeksVariable && is_numeric($element) && $d == "Sat") {
					mysql_query("INSERT INTO table1  
                    (idproducts, info1, info2, info3, info4, info5, info6, fullinfo1, drawndate, drawnyear) VALUES('9', '$variable1[0]', '$variable1[1]', '$variable1[2]', '$variable1[3]', '$variable1[4]', '$variable1[5]', '$variable1[6]', NOW(), NOW())")
							or die(mysql_error());

					mysql_query("UPDATE table2 SET dates = DATE_ADD(DATE_ADD(DATE(NOW() + INTERVAL 3 DAY), INTERVAL 19 HOUR), INTERVAL 00 MINUTE) 
            WHERE idsomething = '9'")
							or die(mysql_error());

					break 1;
				} else {
					echo "'{$element}' is NOT numeric or results same as last week, or It isn't Thursday", PHP_EOL;
				}
			}
		}
}

mysql_close();

Overall the code is quite ... what are you trying to achieve with this?

FabienO · 24 Mar 2012 at 14:00

Try some better structure:

PHP:

foreach ($variable1 as $element) {
	
	if($variable1 != $LastWeeksVariable && isset($d) && $d != '')
	{
		switch($d)
		{
			case 'Tue': 
				/* Setup Values */
				break;
			case 'Thu'
				/* Setup Values */
				break;
			case 'Sat': 
				/*Setup Values */
				break;
			default:
				/* Setup values */				
		}
		
		if($values) { /* Check all values are setup correctly */
			/* Do Query */
			
		} else {
			/* Uh oh! You dun goofed */
		}
	}
}

The goal is to remove redundant data and checks.

craptakular · 24 Mar 2012 at 14:13

ok I will take a look, thanks fab

craptakular · 24 Mar 2012 at 14:23

I'm trying to upload different data to my db based on a day of the week.

craptakular · 24 Mar 2012 at 14:37

OK I now have this, which is much easier to follow. However, it is inserting 7 lines into my db, because of the loop. How do I make it only do a first pass then stop?

It is entering the same line 7 times into my db now.

PHP:

foreach ($variable1 as $element) {
 if($variable1 != $variable2 && is_numeric($element) && isset($d) && $d != '')
    {
        switch($d)
        {
            case 'Tue': 
						mysql_query("INSERT INTO table1
						(idproducts, info1, info2, info3, info4, info5, info6, totalinfo1, drawndate, drawnyear) VALUES('9', '$variable1[0]', '$variable1[1]', '$variable1[2]', '$variable1[3]', '$variable1[4]', '$variable1[5]', '$variable1[6]', NOW(), NOW())") 
						or die(mysql_error());  

						mysql_query("UPDATE table2 SET dates = DATE_ADD(DATE_ADD(DATE(NOW() + INTERVAL 2 DAY), INTERVAL 19 HOUR), INTERVAL 00 MINUTE)
						WHERE idtable2 = '9'")
						or die(mysql_error());
                break;
            case 'Thu':
						mysql_query("INSERT INTO table1
						(idproducts, info1, info2, info3, info4, info5, info6, totalinfo1, drawndate, drawnyear) VALUES('9', '$variable1[0]', '$variable1[1]', '$variable1[2]', '$variable1[3]', '$variable1[4]', '$variable1[5]', '$variable1[6]', NOW(), NOW())") 
						or die(mysql_error());  

						mysql_query("UPDATE table2 SET dates = DATE_ADD(DATE_ADD(DATE(NOW() + INTERVAL 2 DAY), INTERVAL 19 HOUR), INTERVAL 00 MINUTE)
						WHERE idtable2 = '9'")
						or die(mysql_error());
                break;
            case 'Sat': 
                        mysql_query("INSERT INTO table1
						(idproducts, info1, info2, info3, info4, info5, info6, totalinfo1, drawndate, drawnyear) VALUES('9', '$variable1[0]', '$variable1[1]', '$variable1[2]', '$variable1[3]', '$variable1[4]', '$variable1[5]', '$variable1[6]', NOW(), NOW())") 
						or die(mysql_error());  

						mysql_query("UPDATE table2 SET dates = DATE_ADD(DATE_ADD(DATE(NOW() + INTERVAL 3 DAY), INTERVAL 19 HOUR), INTERVAL 00 MINUTE)
						WHERE idtable2 = '9'")
						or die(mysql_error());
                break;
            default:
						echo "error";
        }
    }
}

FabienO · 24 Mar 2012 at 21:54

PHP:

$inserted = false;
foreach ($variable1 as $element) {
 if($inserted) { continue; }
 if($variable1 != $variable2 && is_numeric($element) && isset($d) && $d != '')
    {
        switch($d)
        {
            case 'Tue': 
                        mysql_query("INSERT INTO table1
                        (idproducts, info1, info2, info3, info4, info5, info6, totalinfo1, drawndate, drawnyear) VALUES('9', '$variable1[0]', '$variable1[1]', '$variable1[2]', '$variable1[3]', '$variable1[4]', '$variable1[5]', '$variable1[6]', NOW(), NOW())") 
                        or die(mysql_error());  

                        mysql_query("UPDATE table2 SET dates = DATE_ADD(DATE_ADD(DATE(NOW() + INTERVAL 2 DAY), INTERVAL 19 HOUR), INTERVAL 00 MINUTE)
                        WHERE idtable2 = '9'")
                        or die(mysql_error());
                        $inserted = true;
                break;
            case 'Thu':
                        mysql_query("INSERT INTO table1
                        (idproducts, info1, info2, info3, info4, info5, info6, totalinfo1, drawndate, drawnyear) VALUES('9', '$variable1[0]', '$variable1[1]', '$variable1[2]', '$variable1[3]', '$variable1[4]', '$variable1[5]', '$variable1[6]', NOW(), NOW())") 
                        or die(mysql_error());  

                        mysql_query("UPDATE table2 SET dates = DATE_ADD(DATE_ADD(DATE(NOW() + INTERVAL 2 DAY), INTERVAL 19 HOUR), INTERVAL 00 MINUTE)
                        WHERE idtable2 = '9'")
                        or die(mysql_error());
                        $inserted = true;
                break;
            case 'Sat': 
                        mysql_query("INSERT INTO table1
                        (idproducts, info1, info2, info3, info4, info5, info6, totalinfo1, drawndate, drawnyear) VALUES('9', '$variable1[0]', '$variable1[1]', '$variable1[2]', '$variable1[3]', '$variable1[4]', '$variable1[5]', '$variable1[6]', NOW(), NOW())") 
                        or die(mysql_error());  

                        mysql_query("UPDATE table2 SET dates = DATE_ADD(DATE_ADD(DATE(NOW() + INTERVAL 3 DAY), INTERVAL 19 HOUR), INTERVAL 00 MINUTE)
                        WHERE idtable2 = '9'")
                        or die(mysql_error());
                        $inserted = true;
                break;
            default:
                        echo "error";
        }
    }
}

Though I am fairly sure there's a better method of doing this. When do you call this action?

aln · 25 Mar 2012 at 03:17

Oxy said:

OK I now have this, which is much easier to follow. However, it is inserting 7 lines into my db, because of the loop. How do I make it only do a first pass then stop?

It is entering the same line 7 times into my db now.

PHP:

foreach ($variable1 as $element) {
 if($variable1 != $variable2 && is_numeric($element) && isset($d) && $d != '')
    {
        switch($d)
        {
            case 'Tue': 
						mysql_query("INSERT INTO table1
						(idproducts, info1, info2, info3, info4, info5, info6, totalinfo1, drawndate, drawnyear) VALUES('9', '$variable1[0]', '$variable1[1]', '$variable1[2]', '$variable1[3]', '$variable1[4]', '$variable1[5]', '$variable1[6]', NOW(), NOW())") 
						or die(mysql_error());  

						mysql_query("UPDATE table2 SET dates = DATE_ADD(DATE_ADD(DATE(NOW() + INTERVAL 2 DAY), INTERVAL 19 HOUR), INTERVAL 00 MINUTE)
						WHERE idtable2 = '9'")
						or die(mysql_error());
                break;
            case 'Thu':
						mysql_query("INSERT INTO table1
						(idproducts, info1, info2, info3, info4, info5, info6, totalinfo1, drawndate, drawnyear) VALUES('9', '$variable1[0]', '$variable1[1]', '$variable1[2]', '$variable1[3]', '$variable1[4]', '$variable1[5]', '$variable1[6]', NOW(), NOW())") 
						or die(mysql_error());  

						mysql_query("UPDATE table2 SET dates = DATE_ADD(DATE_ADD(DATE(NOW() + INTERVAL 2 DAY), INTERVAL 19 HOUR), INTERVAL 00 MINUTE)
						WHERE idtable2 = '9'")
						or die(mysql_error());
                break;
            case 'Sat': 
                        mysql_query("INSERT INTO table1
						(idproducts, info1, info2, info3, info4, info5, info6, totalinfo1, drawndate, drawnyear) VALUES('9', '$variable1[0]', '$variable1[1]', '$variable1[2]', '$variable1[3]', '$variable1[4]', '$variable1[5]', '$variable1[6]', NOW(), NOW())") 
						or die(mysql_error());  

						mysql_query("UPDATE table2 SET dates = DATE_ADD(DATE_ADD(DATE(NOW() + INTERVAL 3 DAY), INTERVAL 19 HOUR), INTERVAL 00 MINUTE)
						WHERE idtable2 = '9'")
						or die(mysql_error());
                break;
            default:
						echo "error";
        }
    }
}

Your values should be from element[] not variable1[], otherwise your code makes no sense. Another tip is use PDO, and prepared statements, as opposed to mysql_query, etc.