For the price it is probably hard to beat but the Tamron 24-70mm is much better.
However, it isn't an every day lens at all on a crop camera. Have a look at the Sigma 16-60mm or Tamorn 17-50mm f/2.8 lenses, or better yet is something like the Canon 15-85mm f/5.6. A 24-70mm on crop works well as a portrait lens but for every day use you will be constantly swapping lenses.