Test and find a flaw in this.

[Conrad11]

Hi there,

I am creating the add bit of my CMS and I am parsing the text that is put in. The function i have created is supposed to do the following:

• Put it in valid xHTML
• Put it in paragraphs where appropriate.
• Put linebreaks where appropriate.
• Strip any unnecessary line breaks and paragraphs.
• Use BB Code (this won't product valid HTML yet as i haven't done that bit yet, but it should still display ok)

So could you test it and see if it's doing what its supposed to:

http://customised.live-host.org/test.php

Thanks.

 

[Fireskull]

Hmmmmmmmm

====================

<p>Hmmmmmmmm</p>


Is that what its supposed to output?

 

[Mark M]

scoooby dooooby dooooo

====================

<p>scoooby dooooby dooooo</p>

 

[ChrisB]

Seems to work okay, tried common escape characters, comments functions etc.... Doesn't break it.
BB code doesn't convert smilies though

 

[Dj_Jestar]

Just a note that no matter how trivial it may seem.. attempted 'hacking' whether consented or not is still illegal in a number of places, the UK included.

But don't expect SO19 to be knocking on your door.

 

[Fireskull]

Just a note that no matter how trivial it may seem.. attempted 'hacking' whether consented or not is still illegal in a number of places, the UK included.

But don't expect SO19 to be knocking on your door.

???

 

[Conrad11]

Hi peeps....

Sorry for not explaining very well.

Basically, I want the articles to be formatted properly.

So instead of using a conventional nl2br() function (which would just have <br />'s all over the place), I have created my own which formats the text in paragraphs (how it should be done).

Just wanted to check it works properly.

Thanks for looking.

 

[Dj_Jestar]

???

er.. would you like that in French?

 

[Fireskull]

er.. would you like that in French?

Yes please nm i didnt read properly the first time but i now understand what you mean i think i can hear the choppers coming

 

[Augmented]

Seems fine so far.

I notice slashes are being escaped, which wouldn't be desirable behaviour - may be worth doing a quick check while parsing if you're not already doing this in the proper app.

this is a slash \

=

this is a slash \\

Additionally, i18n strings such as:

東京事変

are converted to their character entity equivalent, but appear to be double-escaped, incorrectly producing:

<p>&amp;#26481;&amp;#20140;&amp;#20107;&amp;#22793;</p>

 

[paulsheffII]

I like the fact it splits by <p> rather than using <br />, but the stripping of linebreaks means I can't double space, which I think if you've got a lot of text split by titled paragraphs would be needed.

 

[Conrad11]

snip

Thanks.

I am not sure exactly why its adding slashes because i havent run the addslashes or mysql escape functions anyways, but when i run the stripslashes() function it removes that. Thanks.

I can't seem to reproduce the second point you made.


EDIT:

I think i have fixed this.

 

[Conrad11]

I like the fact it splits by <p> rather than using <br />, but the stripping of linebreaks means I can't double space, which I think if you've got a lot of text split by titled paragraphs would be needed.

Do you mean double space between paragraphs...yeah?

I could just remove the part where it removes:

<p><br />

...that will let you double space.

 

[Dj_Jestar]

get_magic_quotes_gpc() ?

 

[Conrad11]

get_magic_quotes_gpc() ?

good point, I'll run something to remove that.

 

[Conrad11]

Have updated this now (see link).

It should use BB code: quote, url, bold, italic, underline and format them properly with valid xHTML.

Also fixed any issues stated in this thread. Thanks to those that pointed them out (+solutions).

It also now formats the HTML so when you view the source it's layered.

If anyone else notices anything wrong/needs updating/.... just say....

Thanks for looking.