unexpected T_ELSE

yoda · 28 Jan 2008 at 00:51

Parse error: parse error, unexpected T_ELSE in /srv/www/htdocs/#######/includes/check-loggedin.php on line 13

PHP:

<?php
// this checks that if a user is trying to access a page where they should be logged in that they are actually logged in
// lets see if session is set, if not then they are using anonimous proxies, in which case we don't want them on the site
if (isset($_SESSION)) ($_SERVER['SCRIPT_NAME']) != "/login.php"; 
{
// ok, so, the sesion does exist now look to see if their email is set
if (!isset($_SESSION['USER_EMAIL']))
{ 
// ### need to check if they allready are at the login page... lol ###
// email is not set, theirfor they have not logged in so we bounce them to the login page
header("Location: login.php");
} 
} else
// The session is not set, their is something seriously wrong, so we bounce them to the login page anyways
{ header("Location: login.php");
} ?>

Perhaps it's coz it's after midnight and tomarrow I'll call myself stupid, but I can't find out why it causing an error.

Can anyone see it?

Thanks

Dj_Jestar · 28 Jan 2008 at 00:55

You have one too many }'s

Inquisitor · 28 Jan 2008 at 01:00

Dj_Jestar said:
You have one too many }'s

Nope, he's actually screwed up the condition on the first first if statement, causing the interpreter to interpret the following braces as unbound, which is why an else statement thereafter is not allowed

There are actually no syntax errors up until the else, despite the first conditional statement not actually making sense.

Don't know exactly how the script is supposed to work, but I'm assuming it should be something like this:

Code:

if (isset($_SESSION) && $_SERVER['SCRIPT_NAME'] != "/login.php"))
{
    // ...
}
else
{
    // ...
}

Dj_Jestar · 28 Jan 2008 at 01:03

ah yes.. didn't see it was nested. Indentation is your friend.

yoda · 28 Jan 2008 at 11:19

Inquisitor said:
Nope, he's actually screwed up the condition on the first first if statement, causing the interpreter to interpret the following braces as unbound, which is why an else statement thereafter is not allowed There are actually no syntax errors up until the else, despite the first conditional statement not actually making sense.

Don't know exactly how the script is supposed to work, but I'm assuming it should be something like this:

Code:

if (isset($_SESSION) && $_SERVER['SCRIPT_NAME'] != "/login.php")) { // ... } else { // ... }

But, theirs too many close brackets in that top if statement.....

I tried using &&'s and it just threw it back at me....

the script get ran on every page... it's part of a web based application that i'm creating.
it basically says first it sees if their is a session open, which their should be coz immediatly befor this script it creates one....
Next, is the user email address set if it isn't then their not logged in and they need to go back to the login page....
However, if they are at the login page then they don't need to be sent to the login page....

Does that help?

Thanks

Inquisitor · 28 Jan 2008 at 11:25

yoda said:
But, theirs too many close brackets in that top if statement.....

Good catch

yoda said:
I tried using &&'s and it just threw it back at me....

the script get ran on every page... it's part of a web based application that i'm creating.
it basically says first it sees if their is a session open, which their should be coz immediatly befor this script it creates one....
Next, is the user email address set if it isn't then their not logged in and they need to go back to the login page....
However, if they are at the login page then they don't need to be sent to the login page....

Does that help?

Thanks

Right, if I've understood you correctly, it should be something like this:

Code:

<?php

if (isset($_SESSION))
{
    if (!isset($_SESSION['USER_EMAIL']) && $_SERVER['SCRIPT_NAME'] != '/login.php')
    { 
        header('Location: login.php');
    } 
}
else if ($_SERVER['SCRIPT_NAME'] != '/login.php')
{
    header('Location: login.php');
}

?>

Sic · 28 Jan 2008 at 14:08

holy overcommenting batman!

yoda · 28 Jan 2008 at 14:18

heh, I go from doing NONE at all to very verbose....

At least I can understand what the code is supposed to do... and read me own thaughts.... you should see the notes on the account management scripts.... PMSL

Sic · 28 Jan 2008 at 14:55

they're not as bad as some I've seen - whatever you need to do to keep track of the code. What I can't stand is:

Code:

# check to see if user isn't logged in
if ($_SESSION['islogged'] !== true) {
# send away
  header('Location: /login.php');
}

there's a guy here who does that and it does my brain in!

yoda · 29 Jan 2008 at 11:24

Sic said:
they're not as bad as some I've seen - whatever you need to do to keep track of the code. What I can't stand is:

Code:

# check to see if user isn't logged in if ($_SESSION['islogged'] !== true) { # send away header('Location: /login.php'); }

there's a guy here who does that and it does my brain in!

What does your brain in?

Inquisitor · 29 Jan 2008 at 11:40

yoda said:
What does your brain in?

Mindless 'repeat what the code says' commenting. If you understand PHP, then that code is entirely self-explanatory and no comments whatsoever are needed. If you're going to comment something, at least add something that can't be easily inferred from the code itself

Ideally, you should comment your code on a block level (i.e. comment each logical block/grouping of code) and explain only subtle nuances of the code and why you're doing something, not what you're doing (as the code itself tells you what it's doing). You should only say what you're doing if the code is complex and it isn't immediately obvious what's going on.

yoda · 29 Jan 2008 at 13:31

neh.... to no techies using comments make it so that they can distinguish what the code does and thus you quickly get elevated to godhood.....

Inquisitor · 29 Jan 2008 at 13:33

What?

Sic · 29 Jan 2008 at 14:07

yoda said:
neh.... to no techies using comments make it so that they can distinguish what the code does and thus you quickly get elevated to godhood.....

why would non-technical people be allowed near code? surely they just get the final package

paulsheff · 29 Jan 2008 at 14:57

Code:

if($nor > 0)
{
}// if($nor > 0)
else
{
}// else to if($nor > 0)

I do that... a lot

SpicyDuck · 29 Jan 2008 at 15:02

yoda said:
What does your brain in?

My skull. What?

Sic · 29 Jan 2008 at 15:04

paulsheff said:
Code:

if($nor > 0) { }// if($nor > 0) else { }// else to if($nor > 0)

I do that... a lot

stop it!

paulsheff · 29 Jan 2008 at 17:26

Sic said:
stop it!

Never!

It's all far too confusing without...

Dj_Jestar · 29 Jan 2008 at 18:00

If you used indentation it would be far from confusing.

yoda · 6 Feb 2008 at 21:17

Inquisitor said:
Good catch

Right, if I've understood you correctly, it should be something like this:

Code:

<?php if (isset($_SESSION)) { if (!isset($_SESSION['USER_EMAIL']) && $_SERVER['SCRIPT_NAME'] != '/login.php') { header('Location: login.php'); } } else if ($_SERVER['SCRIPT_NAME'] != '/login.php') { header('Location: login.php'); } ?>

Sorry I not been on a while... my brain exploded...

tried the above and I get....

The page isn't redirecting properly

Firefox has detected that the server is redirecting the request for this address in a way that will never complete.

* This problem can sometimes be caused by disabling or refusing to accept cookies.

Looks like we got an if thats wrong....