ASP experts required

[xirokx]

hi there,

Can someone please tell me why this form does not work and what I need to do to fix it? I am baffled..

http://www.londonairportpickup.com/booking.asp

Thank you in advance

 

[djkav]

Hmm, you haven't described what your problem is and how to recreate it. Also we may need to see your VBScript in your ASP pages.

 

[Stelly]

send me the asp page and I will look at it...

stellyuk at gmail dot com.

Stelly

 

[Ciphon]

Classic ASP /shudder

I'm really no expert with this.. but wouldn't the actual issue lie on booking2.asp (The page booking.asp's form is posting too)?

Would need to see what's happening there.

 

[edscdk]

have you checked the server logs? some times it will tell you the exact error... (if there is an error)

 

[xirokx]

nothing in the log files as far as I can tell

stelly I have just emailed you the ASP pages, let me know if you need anything else

thanks for the education

 

[Stelly]

ok will look at it now since its friday

Stelly

 

[xirokx]

you rock..

 

[xirokx]

page 1 and page 2 work in IE but not in Mozilla Firefox or other browsers..

Page 3 does not work in IE or Mozilla FF i.e. when you click on submit theres a "Microsoft VBScript runtime error '800a01a8'

Object required

/booking3.asp, line 478
" error.. "

hope that helps

 

[Pho]

If you're still stuck you could email me the files as well (sig) or if they're not too sensitive upload them to a pastebin and post the link here.

 

[djkav]

page 1 and page 2 work in IE but not in Mozilla Firefox or other browsers..

Page 3 does not work in IE or Mozilla FF i.e. when you click on submit theres a "Microsoft VBScript runtime error '800a01a8'

Object required

/booking3.asp, line 478
" error.. "

hope that helps

Thats a relatively simple error if we could see the code. Simply means you're trying to access an object thats not been set.

 

[xirokx]

thank you so much


just emailed you 3 pages

djkav - its three pages of code do you really want me to upload it here? sure that error is simple but in the bigger picture the fact it is wont work in FF and whilst page 3 works in IE it stops working when you submit the form as you receive the above error - want me to email you the pages?

 

[Pho]

OK, at the bottom of booking3.asp you have:

<%
478: rs.close
479: set rs = nothing
%>

The error you're receiving is saying that rs is not an object, and as such has no .close() function. To get around this try changing those lines to this:

<%
If IsObject(rs) Then
	rs.close
	Set rs = Nothing
End If
%>

As for the validation, I can make it work in Firefox by modifying the JavaScript function checkFields() on both booking.asp and booking2.asp and putting return; at the top, i.e.:

function checkFields()
{
	return;
	var msg = "";
	var Phone = document.frmBooking.txtPhone.value

	....

which is just stopping the validation code from running. Personally I'd look at using the excellent jQuery Validation plugin instead of your own JavaScript, because it's cross-browser compatible out the box and would let you remove the checkFields function altogether.

 

[Pho]

Infact, here's a way to get validation working in Firefox and IE. Note that I've not tested this in other browsers, so be warned:

booking.asp:

Replace function showDefinition with this:

function showDefinition (id, idOuter, name, definition)
{
	var elements = document.all || document.getElementsByTagName('*');
	var html = "<b>" + name + "</b>&nbsp;-<br>" + definition;
	
	elements[idOuter].style.visibility = "visible";
	elements[id].innerHTML = html;
	return;
}

Booking2.asp:

Replace function showDefinition with this (note that it is different to the above):

function showDefinition (id, idOuter, name, definition)
{
	var elements = document.all || document.getElementsByTagName('*');
	var html = "<b>" + name + "</b>&nbsp<br>" + definition + "<br><br>";
	
	elements[idOuter].style.visibility = "visible";
	elements[id].innerHTML = html;
	return;
}

You'll have to quote my post and then copy the code from there, because the forum is stripping out the br tags when you view it normally above^.

 

[djkav]

Infact, here's a way to get validation working in Firefox and IE. Note that I've not tested this in other browsers, so be warned:

booking.asp:

Replace function showDefinition with this:

function showDefinition (id, idOuter, name, definition)
{
	var elements = document.all || document.getElementsByTagName('*');
	var html = "<b>" + name + "</b>&nbsp;-<br>" + definition;
	
	elements[idOuter].style.visibility = "visible";
	elements[id].innerHTML = html;
	return;
}

Booking2.asp:

Replace function showDefinition with this (note that it is different to the above):

function showDefinition (id, idOuter, name, definition)
{
	var elements = document.all || document.getElementsByTagName('*');
	var html = "<b>" + name + "</b>[B]&nbsp<br>" + definition + "<br><br>";
	
	elements[idOuter].style.visibility = "visible";
	elements[id].innerHTML = html;
	return;
}

You'll have to quote my post and then copy the code from there, because the forum is stripping out the br tags when you view it normally above^.

You missed out the ";" from &nbsp part above.

 

[xirokx]

booking.asp and booking2.asp now work in both IE and Firefox

booking3.asp however does not work

please can you help me resolve it and get it to work? dont know why really...

thanks for you help

cheers

p.s. thanks djkav I noticed I am getting nbsp infront of textfield headers on booking2.asp I think its because of having left out more ";" but dont know where

 

[djkav]

booking.asp and booking2.asp now work in both IE and Firefox

booking3.asp however does not work

please can you help me resolve it and get it to work? dont know why really...

thanks for you help

cheers

p.s. thanks djkav I noticed I am getting nbsp infront of textfield headers on booking2.asp I think its because of having left out more ";" but dont know where

Whats your error on page 3?

Did the IsObject() not work?

 

[djkav]

p.s. thanks djkav I noticed I am getting nbsp infront of textfield headers on booking2.asp I think its because of having left out more ";" but dont know where

function showDefinition (id, idOuter, name, definition) 
{ 
    var elements = document.all || document.getElementsByTagName('*'); 
    var html = "<b>" + name + "</b>[b]&nbsp;" + definition + ""; 
     
    elements[idOuter].style.visibility = "visible"; 
    elements[id].innerHTML = html; 
    return; 
}

The line starting "var html =" I put it in the code above now.

 

[xirokx]

the error I am receiving on booking3.asp is as follows

Microsoft VBScript runtime error '800a01a8'

Object required

/booking3.asp, line 479


any ideas why?

thanks

 

[djkav]

the error I am receiving on booking3.asp is as follows

Microsoft VBScript runtime error '800a01a8'

Object required

/booking3.asp, line 479


any ideas why?

thanks

Email me the page. Click on trust for my email address.