Yeah, they are on ear. I was thinking that getting decent closed isolating full size over ear headphones for £50 would be a tall order. Having said that though, Audio Technica M20X looks like they do isolate quite well from what I can gather looking at some comments. Pretty good going from AT to achieve that with a full size headphone costing £40.
To be honest, I'd forgotten about Goldring NS1000. They used to be a very good choice for active noise cancelling (ANC) headphones, but they were at one point a more expensive headphone that was reduced in price. Headband breakage has always been a weak point Goldring headphones. How these new editions fare in comparison I don't know. They're cheaper. You can't improve build quality by making something cheaper.

That said though the ANC does work well and much better than any other budget headphones with NC.
Build quality aside, the only concern for me would be that when it comes to NC, there's more than just airplane noise. While the NS1000 do well on an airplane, they don't do so well if you want to use them on public transport to drown out voices. I suppose it depends whether you want these
only for airplane use.