I'm thinking of switching from Galaxy S10+ to XS Max, so selling S10+ and getting second hand XS Max. Risky?
Risky in what way? Both devices will provide an equivalent experience within their respective operating systems. Either way, I'd hang on until Black Friday.