If they made the new iPhone the same shape as the new iPad pro with the square edges and rounded corners I would buy one.I would like more industrial look of iphone, like new ipad or iPhone 4. Never been a fan of smooth rounded shape. And I can't believe they don't have smaller components for face ID, after three years...they just want to milk, which will show poorly on their sales, my guess.
So for me still no reason to upgrade from X. Next year, even with only upgrade in features, it will be much bigger update ( hoping for high refresh rate screen, usb c, 5g, smaller front cameras, wifi 6).
USB-C and expandable storage with an SD card.