Checking PHP query is empty

steroyle · 9 Sep 2007 at 14:56

I'm having some trouble trying to display a message if my query returns no records, pretty sure its the if($result == "") part just not sure what it should be.

Code:

$query  = "SELECT * FROM products WHERE `sub_category` = '$pg'";
$result = mysql_query($query);

if($result == "")
{
    echo "This category is empty";
}
else
{
    while($row = mysql_fetch_array($result, MYSQL_ASSOC))
    {		
        echo "<div class=\"productbox\">\n";
        echo "<h2>{$row['product_name']}</h2>\n";
        echo "<p>{$row['product_description']}... <a href=\"moreinfo.htm\">(more info)</a></p><br>\n";
        echo "<div class=\"imagebox\"><img src=\"images/products/{$row['image_name']}\"></div>\n";
        echo "<span class=\"price\">Price: &pound;{$row['product_price']}<br/><a href=\"buy.htm\">Buy Now</a></span>\n";
        echo "</div>\n\n";
    }
}

Thanks in advance

robmiller · 9 Sep 2007 at 15:25

Code:

if ( mysql_num_rows($result) < 1 ) {
    // No rows were returned
}

steroyle · 9 Sep 2007 at 15:38

Thanks for your quick reply rob, it works perfect

Tetsujin · 10 Sep 2007 at 21:03

don't hate me for pedantry but, this is tidier

Code:

if(!mysql_num_rows($result)) {
//no rows
}

as 0 evaluates to false, see, and all other numbers evaluate to true