PHP echo and javascript

davestar_delux · 28 Oct 2009 at 17:25

Hey, I have a webpage displaying a table from a database. I am wanting to make one of the fields trigger a javascript function using the two previous fields as its parameters. I am having trouble passing the parameters to the javascript function using PHP as the line is full of quotation characters something like this:

echo '<td><a href="#" onclick=(' . $string1 . ', ' . $string2 . ')>' . $row[field3] . '</a></td>

That's the best I can recall from memory and it throws up a javascript error. Does anyone know how I can do this?

SimonCHere · 28 Oct 2009 at 18:42

Your onclick should name a function first!

onclick=functionname(' . $sting1 . ',' . $string2 . ')>'

davestar_delux · 28 Oct 2009 at 19:25

SimonCHere said:
Your onclick should name a function first!

onclick=functionname(' . $sting1 . ',' . $string2 . ')>'

Sorry, yeah it already does.

The problem is the parameters passed to the function need to be in quotations I think.

marc2003 · 28 Oct 2009 at 20:12

davestar_delux said:
The problem is the parameters passed to the function need to be in quotations I think.

there you go. you've answered your own question. you just need to escape them as you're using php.

davestar_delux · 28 Oct 2009 at 20:24

marc2003 said:
there you go. you've answered your own question. you just need to escape them as you're using php.

Yes, I don't know how to escape them in the example I have given because I am already using many quotes to do the html and escape the php variables...

marc2003 · 28 Oct 2009 at 20:37

try

echo '<td><a href="blah(\'' . $string1 . '\', \'' . $string2 . '\');">' . $row[field3] . '</a></td>';

Paramount · 28 Oct 2009 at 22:58

What is meant by escape?

CaptainComedy · 30 Oct 2009 at 21:11

Paramount said:
What is meant by escape?

basically being out of "this" and 'this' although "$this" will work just as well as .$this.... sooooo:

$this = "test";
$variable1 = "$this";
$variable2 = $this;

echo "$variable1 is the same as $variable2"

you'll end up with "test is the same as test"

but to answer:

echo '<td><a href="#" onclick=(' . $string1 . ', ' . $string2 . ')>' . $row[field3] . '</a></td>

try

echo "<td><a href='#' onclick=('$string1, $string2')>" .$row['field3'] ."</a></td>";

or try

echo "<td><a href='#' onclick=('$string1, $string2')>$row['field3']</a></td>";

just noticed at the end of your script you didn't close the echo with '; that will definately kill it.