Php, not getting any errors yet this code wont update database

[jamesmorris86]

Hey guys, can anyone see what i have done wrong on this code, instead of updating my database it just does nothing at all, no errors, no noting.

if ($enemy_hp <= 0) {

$sql = "UPDATE game_status SET battle = '1' WHERE id=1";

} else {

$sql = "UPDATE game_character SET current_hp = (current_hp-100) WHERE id=1";


    $statement = $dbh->prepare($sql); 
    $statement->execute();

}

 

[FabienO]

tried running the queries directly in the db?

 

[jamesmorris86]

No, but I had them running fine before I put them in the if else.

 

[tntcoder]

From your code, you are only executing the query if the else block is triggered.

If you enter the if condition block then you only set $sql and never run the query.

 

[jamesmorris86]

Oh ok, is there any way around this? I tried changing the logic so that a query is defined in the if() and in the else, but im still not having any luck.

 

[tntcoder]

Cant you just do this and execute it after the condition:

$sql = "";

if ($enemy_hp <= 0) { 
$sql = "UPDATE game_status SET battle = '1' WHERE id=1"; 
} 

else { 
$sql = "UPDATE game_character SET current_hp = (current_hp-100) WHERE id=1"; 
}

echo $sql;
$statement = $dbh->prepare($sql);  
$statement->execute();

 

[jamesmorris86]

I tried that way but it executes the first query regardless of $enemy_hp

 

[tntcoder]

Something is wrong with the value of $enemy_hp then, the logic is correct. I suggest echoing out the value of it before the condition check.

 

[jamesmorris86]

Cant see anything wrong with the variable, its echo'ing fine, maybe I should look at it tomorrow with fresh eyes.

Thanks for your help

 

[visibleman]

Cant see anything wrong with the variable, its echo'ing fine, maybe I should look at it tomorrow with fresh eyes.

Thanks for your help

So it's echo'ing the correct query but executing the first?
Try replacing the SQL string with the prepare function and seeing that makes a difference (shouldn't if the IF statement is working correctly ie: the $SQL is being echoed correctly) -

if ($enemy_hp <= 0) { 
$statement = $dbh->prepare("UPDATE game_status SET battle = '1' WHERE id=1"); 
} else { 
$statement = $dbh->prepare("UPDATE game_character SET current_hp = (current_hp-100) WHERE id=1"); 
}
$statement->execute();

 

[aln]

I have slightly extended the code to maybe help you.

$dsn		= '';
$user 		= '';
$pass		= '';
$enemy_hp 	= 5;

if ($enemy_hp <= 0) 
{
	$sql = "UPDATE game_status 
		SET battle = '1' 
		WHERE id = 1";
} 
else 
{
	$sql = "UPDATE game_character 
		SET current_hp = (current_hp-100) 
		WHERE id = 1";
}

try
{
	$dbh = new PDO("$dsn", "$user", "$pass");
	$dbh->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
	$statement = $dbh->prepare($sql); 
        $statement->execute();
        if ($statement->rowCount() < 1)
        {
                   //i suspect you may want to handle this.
        }
}
catch(PDOException $e)
{
	$msg = $e->getMessage();
        echo $msg;
        log($msg);
}