Rate my QoS Cisco config

[growse]

I'm on a Cisco 877 here, and am just setting up a voip phone. I want to make sure that voip traffic gets prioritised as much as possible, so came up with the following config. Is there anything else I should be doing or thinking about, or any obvious problems? It seems to work ok, with voice quality being ok whilst a big torrent and lots of http downloads are going on.

class-map match-any BESTEFFORT
 match protocol http
 match protocol secure-http
 match protocol icmp
 match protocol secure-imap
 match protocol smtp
 match protocol ipv6
 match protocol ssh
 match protocol dns
class-map match-any REALTIME
 match protocol rtp
 match protocol rtcp
 match protocol sip
class-map match-any SCAVENGER
 match protocol bittorrent
!
!
policy-map POLICY
 class REALTIME
    priority 30
  set ip precedence 5
 class BESTEFFORT
    bandwidth percent 50
 class SCAVENGER
    police 10000 2000 2000 conform-action transmit  exceed-action drop  violate-action drop
  set precedence 0

POLICY is then applied outbound on ATM0.

 

[Skidilliplop]

Proof of pudding to be found in eating.

If you tested it with torrents running then you can be fairly sure it works. You're not likely to use anything more connection/bandwidth intensive than torrents on a day to day basis.

Rule 1 of network administration, don't second guess. If you set it up and it appears to work, stop thinking about it, take all the credit then move on to the next job