really simple Shell scripting help needed

[brendan]

Hello all

I just dont understand this anymore, maybe its just late or something but this is killing me. Whats wrong with this?

      dirname=${fspec#/}
      dirname=${dirname%/*}
      echo "$dirname" >&2
      if [ $dirname != $previousdir ]; then
        echo "YESSSSSSSSSSSSS" >&2
      else
        echo "Allready done" >&2
      fi
      previousdir=$dirname

The if statement is giving me this error line 225 is that if statement. If i remove it the code works fine.

line 225: [: too many arguments

Thanks!

 

[SimonCHere]

try -ne rather than !=
in the if?

And it's been a while but do you need the ; before the "then"?

 

[brendan]

Got it working with :

      [ "$prevdir" != "$currentdir" ]
      if [ $? == 0 ]; then

The -ne only works for Ints I believe.

Chers anyways

 

[whitecrook]

if you had double quoted the first example like the way you did in the second it'll probably work.