Four grand buys you 4,012 litres of petrol at today's prices. With say a 10 mpg improvement from the diesel how long will that take you to break even? I'm on my phone and posting in a hurry, but I'd suggest the answer is "too long".
To add to all the other stuff about what he "gets, and doesn't get" for the extra £4k, I'll put up some proper figures for the fuel consumption issue.
At 18k per annum, based on fuel prices of £1 per liter for both (as an average), with the petrol doing 32 mpg, and the diesel doing 45 mpg, again, on average, the difference in fuel costs is around £730 per year. There will also likely be around £100 a year in VED savings to be had on the diesel too.
So about £830 per year. So it would take a little over 57 months to "pay back" the £4k outlay on just fuel and VED. Assuming the same maintenance and servicing costs. Sure, the anti-diesel brigade will come along with the DMF's this and DPF's that, but the 2.5T will surely have similar issues applicable to it (no DPF obviously though, although it doesn't sound like that should be too much of a worry with the OP's mileage). I doubt there would be huge amounts of difference between the two.
Of course, as Fox rightly points out, the newer car will be worth more than the older car, and will continue to be throughout it's lifetime. So he will see some of that extra money back on the back end. And being the diesel, will hold it's value slightly better anyway.
I would suggest it would probably take around 3 years to "break even" on the trade up. But there is value to be had in driving a newer car too. What that value is worth is entirely dependent on the individual though, so I couldn't put a figure on it.
Petrol is cheap, just now, but it wont always be. And it quickly gets old having to fill the tank every 350 miles, when you could be doing it at closer to 600+ miles. I do 25k+ a year, and wouldn't be without a diesel. I simply dont want to be at the garage every other day, dropping another £70 into the pumps.