Did your Macbook Pro come with DDR2 or 3? If it came with DDR3, you can't use DDR2 in it.
There we go. Bang 4gb in mate, 8gb's just too rich for my tastes, and most people's in my experience. 4gb is plenty for the vast majority of people anyway unless you're doing lots of rendering and stuff.