Woah, thanks for the long comment!
Had a quick look through the replay, main thing I'd recommend you focus on is simply learning a decent build and executing it smoothly. From the replay, it appears you know roughly what you want to be achieving but your gas timings etc aren't lined up with that, indicating you're pretty much just building what you think seems right rather than following a build. This can be good but only after you've got a few builds under your belt first. Also you didn't get your production fast enough which is why you were floating minerals. If you're donig a 2 gate expo then you want to stick with 1 gas until you have your nexus down.
You're pretty much bang on there. Before I stopped I was trying out an FFE build against zerg, but yeah, I was essentially building when it seemed right, and as and when I needed stuff, rather than being able to plan ahead. Some of my failures for the build I put down to being away from the game for a while, I could still remember the basics, but that's not really enough.
Also it's REALLY important to use hotkeys for production - i noticed you went round and clicked on each nexus individually to queue up probes. This is ok when you've nothing else to do but if you get used to using hotkeys you'll notice you suddenly have a lot more time free to do other things, like scouting etc, because you'll be executing the basic macro much faster.
Yeah, I usually have a hoykey for each nexus, then group the robos together, and stargates together. That just slipped again annoyingly.
Your building placement also could be improved. Against zerg you really want a small wall (not 3 zealots wide) and later gateways can be placed either to wall of your natural, or clustered tightly in your main in an organised way. When I play P i like to build in tight columns, alternating between gateways/tech structures and pylons. This avoids "artosis pylons".
Good points. My pylons have always been stuck down fairly randomly, as I often end up in the position of 'Ack, I need to stick one down right now or I'll be blocked!' and thus don't put nearly as much thought into the placement as I should.
As you said, your macro is your weakness (as is the case with nearly everyone below masters including me). You went up to 2400/1000 during your first push. Off of 2 reasonably saturate bases you can support 6 gates and a robo and double ups, while you had only 4/1/1. Factor in your big gaps between production rounds, and you should probably have more like 10 gateways, 2 robos, and 2 forges. As you get better at warping in as soon as the cooldown finishes, you can reduce the number of gateways down to 6/7 but still have the same army size. A good rule is that if you have more than 400minerals or gas and you're not maxed out, you need to build more production structures. Once you're maxed and on 3 bases, it's common to see protosses going up to 15 or even 20 or more gateways.
Below diamond, overbuilding production structures, making sure you constantly produce workers up to 75ish, and taking your 3rd at 11mins (assuming you've been left alone) are the 3 biggest things to focus on.
Very good points. I know that harassment is also something I need to work on, early on in the game I know I play too defensively, preferring to keep in my base and getting an observer up fairly quickly to keep an eye on what my opponent's doing. I know this usually leads to them macroing up as well, especially when playing Zerg, but I've always played RTS games defensively as a turtler, and its hard to break out of that mindset. Especially when its 'Well, I could attack, but what if he's attacking me! Better keep my army here to defend, just in case!'
Though I was doing warp prism harass fairly well before I paused, dropping speed zealots into the mineral line, occasionally accompanied with DTs if they don't have any detection.
Also, carriers are the best unit in the game
