8BitDo N30 for NES, GB, GBC, GBA
8BitDo M30 for Sega MegaDrive, Sega Saturn and 32X
Playstation DualShock 3 for PSOne, SNES
Official GameCube controller with Mayflash adapter for GameCube, also have the Bongo drums
Official N64 controller with rumble Pak connected using Raphnet adapter
Fight stick for arcade
For current games I used a DS4 until I sold my PS4, so just bought myself an Xbox controller
For me it's all about the button placement, I wanted to get as close as possible.