Depends why you want to switch to be honest.
The P30 Pro beats the S10+ in a few areas, but also loses in some. The cameras each do different things slightly better - S10 has better video options and better wide angle, P30 Pro has better night mode and telephoto, standard images tend to be more colour accurate on the S10, but Huawei has their crazy post processing that can look great, but can also sometimes look overly sharpened. Both company's android skins are fairly decent, probably comes down to preference and definitely not a big deal.
P30 Pro has better battery life and charging speed, S10+ has better display, speakers and internal hardware.
That's my take on each phone at least, so personally wouldn't consider it an upgrade, but it depends on your usage. If you really have an upgrade itch, I've heard good things about the Oneplus 7 Pro, might be worth a look. Other than that, there's not much on the market I think that really pulls ahead of the S10+.