some of the leds are out of shape but its not bad for a first attempt.
If I may be a little critical here you've not lined up one of the LEDs correctly. The top left one seems to be out of position is relation to the rest. I like how you've lined them up with the fan frame but that top left one seems like it should be a bit more to the clockwise.
this will be in a push/pull configuration with a shinobi xl case thats why the leds are facing upward.
It's harder on the other side of the fan because the blades are slightly offset. Never tried one on that side to be honest.
Have you got them pointing at the fan blades at all? It almost looks like you've got them pointing right out of the fan into the airstream.
Just had a look back at my original images and even without special orientation the LED effect falling on the blades is pretty nice on the other side of the fan, especially at night.
Anyhow is it normal for circuit to be slightly warm?
The resistors do get a little warm as they have to dump 0.1W of energy as heat, this is of course assuming you have 4 LEDs per resistor like my original schematic.
The LEDs themselves only get slightly warm. If they are hot then you might be running too much current through them.
oh and leds lookj sort of orange (they are yellow to match fan) in daylight is that cause of the resistors? (100 ohm's i think)
Some Yellow LEDs do appear slightly orange. Quite often they are described as yellow-amber because the wavelengths are quite similar. I bought a LED strip that was supposed to be orange and it turned out yellow/amber.
Good job though. It's not for the faint of heart these LED fan mods. Bet it'll look great in the dark.