They nearly had me with the battery and camera.
Then I used the XR for a bit while I was waiting for my Pixel 2 XL to be fixed. Initially I liked it (grass is always greener and all that), but after a few weeks I couldn't wait to give it back.
This surprised me as an iPad Pro user; although I have to admit I'm not sure I would buy another iPad; although its trying to do the whole laptop thing, I find the whole thing rather restrictive, somewhat unintuitive at times, and seems to require daft workarounds to do things that would be really easy on a laptop. Even basic stuff like split screen is not overly intuitive, and their current take on multiple app windows is so confusing many wont even bother trying. It has a really steep learning curve for something touted as being for "non-techies". The only reason I haven't switched is because the iPad is really just a toy, it plays Youtube and Netflix, it browses forums, it's used for reading Kindle or Readly. It does all of these things just as well as a laptop would, but the second I try to do anything remotely "serious" on it, its a pain in the bumhole.
When I had the XR I also appreciated some of the ecosystem benefits, but found that was not a big deal really. Yes it was occasionally useful to be able to open a tab from my phone on the iPad or vice versa, but Chrome does this already. I don't use iMessage so that was of no benefit. Yes I liked that when I went away and I got my iPad out, it asked if I wanted to use my phone as a hotspot, however, once the iPad is paired to a wifi network, all you really need to do is turn on the hotspot anyway.
I'm also really not a fan of the UI - purely personal preference but it's somewhat childish looking with its cartoon like icons, and stuff like unicorns on the keyboard that regularly kept coming back despite me hiding them was really annoying. Yes I could change the keyboard, but the way that worked was clunky too. The final decider was price. Yes, the iPhone is a great piece of hardware, but in the end, Android just feels better for me. It feels much more powerful, less restricted and the Pixel UI is for me more pleasing and mature.
They do a lot of things pretty well, if you're prepared to go all in with Apple, but otherwise, at best it was no better, and at worst, it was a pain.