Any reason to upgrade this year or should I hold onto my X?
iPhone X users could be in a difficult position this year, if a revised 12s (13) or wait for a 14 is going to be tough.
I was thinking about upgrading from my X this year because I was having a few issues with the X and the battery was largely shot but I took it to a local apple approved shop and got the battery replaced (apparently they replace the mic/ speaker at the same time) and its been perfect ever since.
Unless you really care about the camera or need a feature of the latest and greatest iPhone there still isn't a compelling reason to upgrade from any of the iPhones of the past 4 years. The X is still an amazing phone, I love the size, the shape and the speed of it and I don't worry about breaking it and I pay about £9/month on my contract as I bought it outright for about £550 10 months after it was released. So far its cost me on average about £25/month over the last 3 years for my phone/contract.