As I said, I'm not a fan of cloud storage for photos/videos so that's part of it.
Over a number of years and phones I tend to keep the photos sorted in folders for trips/events/etc on a MicroSD card that can simply be moved from phone to phone when I upgrade (sometimes upgrading the MicroSD card capacity). While in theory the built-in phone storage should be very fast, when connected to a Windows PC to manage files via MTP/PTP modes, my experience is that it can be pretty flaky and not quite as reliable as popping a MicroSD card into a card reader.
And then more recently there's the fact that newer phones with higher resolution video recording can eat lots and lots of storage.
I accept that I am in the minority when it comes to preference of having lots of local phone storage capacity.